Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/v2 http-plugin dangerous settings / disable ssl verification - issue #518 #2204

Merged
merged 16 commits into from
Jan 22, 2025
Merged

Feature/v2 http-plugin dangerous settings / disable ssl verification - issue #518 #2204

merged 16 commits into from
Jan 22, 2025

Conversation

RickeyWard
Copy link
Contributor

@RickeyWard RickeyWard commented Dec 13, 2024 •
edited
Loading

Since the HTTP plugin uses Reqwest under the hood, this adds the ability to set Reqwest client builder flags for danger_accept_invalid_certs and danger_accept_invalid_hostnames

Its on the roadmap as a proposal via #518

I'm uncertain how versioning works with the plugins-workspace monorepo, but I bumped the version of the http plugin.

I put this behind a feature flag for security reasons.

I attempted to follow existing conventions as closely as possible.

API changes allow for

await response = fetch("https://expired.badssl.com", 
                                          { danger: { acceptInvalidCerts: true, acceptInvalidHostnames: true } }
                             );

@RickeyWard RickeyWard requested a review from a team as a code owner December 13, 2024 18:18
@FabianLars
Copy link
Member

I'm uncertain how versioning works with the plugins-workspace monorepo, but I bumped the version of the http plugin.

No manual version bumps, only change files like https://github.com/tauri-apps/plugins-workspace/blob/10ce3537b460a1e72e8c9063f6ad910a24140664/.changes/persist-cookies.md

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 15, 2024 •
edited
Loading

Package Changes Through ef5f249

There are 2 changes which include http with minor, http-js with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.14 2.0.15
api-example-js 2.0.10 2.0.11
http 2.2.0 2.3.0
http-js 2.2.0 2.3.0

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

tweidinger
tweidinger previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@tweidinger tweidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RickeyWard
Copy link
Contributor Author

Anything else I need to do to get this merged?

@FabianLars
Copy link
Member

Anything else I need to do to get this merged?

Nope, just waiting for reviews.

@amrbashir amrbashir merged commit 1051364 into tauri-apps:v2 Jan 22, 2025
2 checks passed
@github-actions github-actions bot mentioned this pull request Jan 22, 2025
Merged
@robertdfrench
Copy link

@RickeyWard out there disabling tls smh...

@RickeyWard
Copy link
Contributor Author

RickeyWard commented Jan 22, 2025 •
edited
Loading

@RickeyWard out there disabling tls smh...
@robertdfrench
lol, certificate validation doth not a TLS make. In seriousness, I built a postman like API testing tool and self-signed certs was a requirement. This is locked behind a package feature flag for good reason. 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

@tweidinger tweidinger tweidinger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RickeyWard @FabianLars @robertdfrench @tweidinger @amrbashir